[Bug 705870] audiobasesink: add callback for custom logic based on the sink's average skew value
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Aug 15 01:29:00 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=705870
GStreamer | gst-plugins-base | git
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #251626|none |needs-work
status| |
--- Comment #6 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-15 08:28:55 UTC ---
Review of attachment 251626:
--> (https://bugzilla.gnome.org/review?bug=705870&attachment=251626)
Looks almost good, could you add a link to the bug URL in the commit message?
Also would be good to get Wim's ok on this patch :)
::: gst-libs/gst/audio/gstaudiobasesink.c
@@ +772,3 @@
+ g_return_if_fail (GST_IS_AUDIO_BASE_SINK (sink));
+
+ GST_OBJECT_LOCK (sink);
If there already was a callback set, it should call the destroy notify first
before setting the new one
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list