[Bug 705993] aiffparse: fix push mode / add tests

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705993
  GStreamer | gst-plugins-bad | git

--- Comment #8 from Matthieu Bouron <matthieu.bouron at collabora.com> 2013-08-15 14:01:23 UTC ---
(In reply to comment #3)
> Review of attachment 251614 [details]:
> 
> ::: gst/aiff/aiffparse.c
> @@ +1713,3 @@
> +      /* some debug output */
> +      gst_event_copy_segment (event, &segment);
> +      GST_DEBUG_OBJECT (aiff, "received newsegment %" GST_SEGMENT_FORMAT,
> 
> It's not newsegment, it's segment :) Same in a few other places in this patch

Fixed in new patch.

> 
> @@ +1717,3 @@
> +
> +      if (aiff->state != AIFF_PARSE_DATA) {
> +        GST_DEBUG_OBJECT (aiff, "still starting, eating event");
> 
> The demuxer should still take into account the upstream segment when generating
> its initial segment event if upstream is in TIME format at least

Fixed in new patch.

> 
> @@ +1776,3 @@
> +        gst_event_unref (aiff->start_segment);
> +      GST_DEBUG_OBJECT (aiff, "Storing newseg %" GST_SEGMENT_FORMAT,
> &segment);
> +      aiff->start_segment = gst_event_new_segment (&segment);
> 
> You can just push the segment event here, if you get a segment event from
> upstream the demuxer is running in push mode and the event is received from the
> streaming thread

start_segment is automatically pushed in the parse_stream_data function which
is called after the headers parsing function if aiff->state != AIFF_PARSE_DATA.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.