[Bug 705452] regression: h264parse: Does not extract width/height/etc from h264-in-mpeg-ps
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Aug 20 06:06:22 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=705452
GStreamer | gst-plugins-bad | git
Matthieu Bouron <matthieu.bouron> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |matthieu.bouron at collabora.c
| |om
--- Comment #5 from Matthieu Bouron <matthieu.bouron at collabora.com> 2013-08-20 13:06:19 UTC ---
(In reply to comment #4)
> Review of attachment 252371 [details]:
>
> ::: gst/videoparsers/gsth264parse.c
> @@ +1888,3 @@
> + /* do not set CAPS before SPS/PPS nals parsing */
> + if (!h264parse->have_sps || !h264parse->have_pps)
> + return TRUE;
>
> I'm not sure if that is enough, also it would seem cleaner to just put the
> negotiate block below in an if (have_sps && have_pps) block.
Fixed locally.
>
> The problem I see here is that handle_frame() will immediately call negotiate()
> again, which might be before the SPS/PPS are parsed.
As far i understand calling _negociate without SPS/PPS is not a problem since
it does not directly set the caps but rather update it + format/align. Only
_update_src_caps should not be called before any SPS/PPS parsing.
Calls to _update_src_caps are automatically triggered when SPS/PPS are parsed
(h264parse->update_caps = TRUE).
Should a check be added before calling _negociate in _handle_frame() ?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list