[Bug 697239] [mpegtsmux] Let prog-map define the program number
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Aug 21 02:09:30 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=697239
GStreamer | gst-plugins-bad | 1.x
Edward Hervey <bilboed> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #240573|none |needs-work
status| |
--- Comment #3 from Edward Hervey <bilboed at gmail.com> 2013-08-21 09:09:23 UTC ---
Review of attachment 240573:
--> (https://bugzilla.gnome.org/review?bug=697239&attachment=240573)
apart from the comments, looks good to me.
::: gst/mpegtsmux/tsmux/tsmux.c
@@ +469,3 @@
+static gint
+tsmux_program_compare (gconstpointer * a, gconstpointer * b)
You could just move this before where it's being used and avoid the forward
declaration.
@@ +474,3 @@
+ gint *needle = (gint *) b;
+
+ return (program->pgm_number - *needle);
Just make the arguments of this compare function be (TsMuxProgram *program,
gint *needle) and remove the temporary variables.
You'll then need to cast this function to (GCompareFunc) when you provide it to
g_list_find_custom.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list