[Bug 704760] opencv: disparity-map calculation element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704760
  GStreamer | gst-plugins-bad | 1.x

--- Comment #18 from Miguel (elmiguelao) Casas-Sanchez <miguelecasassanchez at gmail.com> 2013-08-22 12:26:26 UTC ---
(In reply to comment #16)
> (In reply to comment #13)
> 
> > > @@ +591,3 @@
> > > +  g_mutex_unlock (fs->lock);
> > > +
> > > +  ret = gst_pad_push (fs->srcpad, buffer);
> > > 
> > > As the right buffer is always the one that is forwarded it would make sense to
> > > proxy the allocation query from the right sinkpad to the srcpad
> > 
> > I don't really understand that :)
> 
> In the query function of the right sinkpad, when you receive an ALLOCATION
> query, you should forward this query to the srcpad. But only for the right
> sinkpad (as that is the one that gets the buffers which are forwarded
> downstream). That way upstream of the right sinkpad will ideally allocate
> buffers via a buffer pool that is provided by the sink.

Hopefully done as well :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.