[Bug 706054] move GstEGLImageBufferPool and allocator from eglglessink to gstegl lib

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706054
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252934|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-26 08:10:41 UTC ---
Review of attachment 252934:
 --> (https://bugzilla.gnome.org/review?bug=706054&attachment=252934)

::: gst-libs/gst/egl/egl.h
@@ +71,3 @@
+    GstEGLContext * eglcontext);
+gboolean gst_context_get_egl_context (GstContext * context,
+    GstEGLContext ** eglcontext);

I don't think an EGLContext should be distributed via GstContext. Why would you
want to do that? Every element should probably have its own

@@ +92,3 @@
+
+EGLConfig gst_egl_display_get_config (GstEGLDisplay * display);
+void gst_egl_display_set_config (GstEGLDisplay * display, EGLConfig config);

As said above, no GObject-like EGL bindings. People can just call EGL API
themselves.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.