[Bug 693772] avdec: decoder frame list getting long

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693772
  GStreamer | gst-libav | git

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2013-12-01 11:12:45 UTC ---
Did some more testing and seems to work out fine.

Fwiw, looks like the avi clips mentioned here contain not-codec (null vop
frames), which are being discarded. Afaik, those are typically inserted by
mencoder/libav when muxing an avi if needed to preserve a/v sync.  So libav is
likely doing the right thing in discarding these, and we should now be handling
this as well.

Will stick to these patches for now, and move to the GstVideoDecoder _NO_FRAME
approach following more field/master testing.

[in -base]
commit 40fc3060174bc402fdd9584b09b917d696a40724
Author: Mark Nauwelaerts <mnauw at users.sourceforge.net>
Date:   Tue Nov 26 20:50:33 2013 +0100

    videodecoder: make _release_frame external API

    ... so subclasses can release a frame all the way (also from frame list)
    without having to pass through _finish_frame or _drop_frame.
    The latter may not be applicable, or may or may not have already
    been called for the frame in question.

    See https://bugzilla.gnome.org/show_bug.cgi?id=693772

[in -libav]
commit fa5865c0cdab48c6701fdf6f437ccaea3ab3286a
Author: Mark Nauwelaerts <mnauw at users.sourceforge.net>
Date:   Tue Nov 26 20:57:37 2013 +0100

    avviddec: discard unused input frames

    ... to avoid these piling up in list of pending frames.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=693772

commit 2ec4008ea5f3296f50d56b11422ed5d56de6692b
Author: Mark Nauwelaerts <mnauw at users.sourceforge.net>
Date:   Tue Nov 26 20:55:43 2013 +0100

    avviddec: really release frame at proper time

    ... by also removing it from the pending list of frames,
    where it may still be in if it has never been submitted to _finish.
    This could happen if is a decode-only frame, or in skipped decoding
    situation, ...

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=693772

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.