[Bug 696437] qtmux: add support for mp4 timed text

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=696437
  GStreamer | gst-plugins-good | git

--- Comment #12 from Matej Knopp <matej.knopp at gmail.com> 2013-12-01 20:34:52 UTC ---
> +  if (params->subtitle_sink_caps) {
> Shouldn't you check for non-empty caps here? You use GST_STATIC_CAPS_NONE below

This is actually handled in gst_qt_mux_register
    params->subtitle_sink_caps =
        gst_static_caps_get (&prop->subtitle_sink_caps);
    if (gst_caps_is_empty (params->subtitle_sink_caps))
      params->subtitle_sink_caps = NULL;

> Why don't you just use strnlen() here?
Not sure really, gstregistrychunks.c has its own implementation as well, I
though that there are some compatibility issues

> You could just reuse the GString memory here and use gst_memory_new_wrapped()
Which flags should I use?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.