[Bug 719373] Add multifilesrc support to GES

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Dec 2 03:23:43 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=719373
  GStreamer | gst-editing-services | git

Mathieu Duponchelle <mathieu.duponchelle> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263264|none                        |reviewed
             status|                            |

--- Comment #9 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2013-12-02 11:23:39 UTC ---
Review of attachment 263264:
 --> (https://bugzilla.gnome.org/review?bug=719373&attachment=263264)

Apart from my last comment, I think we're good to go :)

::: ges/ges-multi-file-source.c
@@ +181,3 @@
+    stream_info = ges_uri_source_asset_get_stream_info (asset);
+    g_assert (stream_info);
+    disc_caps = gst_discoverer_stream_info_get_caps (stream_info);

You still need to unref these caps, as you copy them after, the doc of
stream_info_get_caps says "unref after usage". Alternatively, you might also
just do :
caps = gst_discoverer_stream_info_get_caps (stream_info); I think :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list