[Bug 679878] [0.11][videodecoder] Need explicit negotiation method

Mon Dec 2 04:04:55 PST 2013

https://bugzilla.gnome.org/show_bug.cgi?id=679878
  GStreamer | gst-plugins-base | 0.11.x

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julien.isorce at gmail.com

--- Comment #8 from Julien Isorce <julien.isorce at gmail.com> 2013-12-02 12:04:46 UTC ---
hi, I noticed that GstVideoDecoder::gst_video_decoder_negotiate does not clear
the GST_PAD_FLAG_NEED_RECONFIGURE flag when it succeeds.

It causes to negociate again, so query allocation is done twice. (the second
time in gst_video_decoder_allocate_output_frame).

Is it expected ? Is the subclass of GstVideoDecoder responsible for clearing
the flag when manually calling gst_video_decoder_negotiate ?

It happens in the following pipeline:

gst-launch-1.0 v4l2src io-mode=mmap ! jpegdec ! xvimagesink

Since recently it seems that initially a pad is set to
GST_PAD_FLAG_NEED_RECONFIGURE : 
http://cgit.freedesktop.org/gstreamer/gstreamer/tree/gst/gstpad.c#n1080

Since this commit:
http://cgit.freedesktop.org/gstreamer/gstreamer/commit/gst/gstpad.c?id=c279bdb663de532be58b31970b26ff515ff4f098

The negotiation design:
http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/design/part-negotiation.txt

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.