[Bug 719684] [GstVideoDecoder] allocation query is always at least sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719684
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263299|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-02 15:50:49 UTC ---
Review of attachment 263299:
 --> (https://bugzilla.gnome.org/review?bug=719684&attachment=263299)

Fix the commit message please, just start with videodecoder: and add the bug
URL

::: gst-libs/gst/video/gstvideodecoder.c
@@ +3198,2 @@
   GST_VIDEO_DECODER_STREAM_LOCK (decoder);
+  if (klass->negotiate && gst_pad_check_reconfigure (decoder->srcpad)) {

This means that calling negotiate explicitly might not trigger another try of
negotiation. This is a change in behaviour, and e.g. will cause problems if
priv->output_state_changed but the reconfigure flag is not set on the pad.

Always call ->negotiate(), and then mark the pad is not needing reconfiguration
if negotiation succeeded

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.