[Bug 719684] videodecoder: Allocation query is always at least sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719684
  GStreamer | gst-plugins-base | git

--- Comment #7 from Julien Isorce <julien.isorce at gmail.com> 2013-12-03 11:30:44 UTC ---
(In reply to comment #5)
> (In reply to comment #4)
> > I think if the  downstream element sends a reconfigure event, the call to
> > "klass->negotiate (decoder)" from "gst_video_decoder_negotiate" will be done
> > automatically when the decoder calls any of the following functions:
> > 
> > gst_video_decoder_allocate_output_buffer
> > gst_video_decoder_allocate_output_frame
> > gst_video_decoder_finish_frame
> 
> Yes, it will be called in these cases. But also subclasses often call it from
> e.g. GstVideoDecoder::set_format() to let negotiation happen ASAP.

I think 

need_reconfigure = check_reconfigure (pad);
"if (klass->negociate && need_reconfigure) then negotiate() ..."

would be ok also for the asap case GstVideoDecoder::set_format() because a pad
is initially marked GST_PAD_FLAG_NEED_RECONFIGURE (see comment #1)

But it depends if a pad goes to inactive when going to ready state. And I'm not
sure about that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.