[Bug 719791] v4l2sink: enable zero-copy path between mfcdec and v4l2sink io-mode=mmap

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Dec 3 11:14:50 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=719791
  GStreamer | gst-plugins-good | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263412|none                        |reviewed
             status|                            |

--- Comment #8 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2013-12-03 19:14:45 UTC ---
Review of attachment 263412:
 --> (https://bugzilla.gnome.org/review?bug=719791&attachment=263412)

::: sys/v4l2/gstv4l2sink.c
@@ +634,1 @@
   /* we need at least 2 buffers to operate */

Might be better inside the if

@@ +634,2 @@
   /* we need at least 2 buffers to operate */
+  if (pool) {

Can it really be NULL ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list