[Bug 719684] videodecoder: Allocation query is always at least sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719684
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263387|accepted-commit_now         |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-04 11:50:04 UTC ---
Review of attachment 263387:
 --> (https://bugzilla.gnome.org/review?bug=719684&attachment=263387)

::: gst-libs/gst/video/gstvideodecoder.c
@@ +3249,3 @@
   if (G_UNLIKELY (!decoder->priv->output_state
           || decoder->priv->output_state_changed
           || gst_pad_check_reconfigure (decoder->srcpad))) {

There's a bug here btw, and in all the other patches. You only check and unset
the reconfigure flag if any of the other conditions fails. So will go here
twice still if first one of the other conditions is true.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.