[Bug 719359] vp8dec: Doesn't handle changes in resolution

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719359
  GStreamer | gst-plugins-good | 1.0.10

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262856|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-05 15:15:05 UTC ---
Review of attachment 262856:
 --> (https://bugzilla.gnome.org/review?bug=719359&attachment=262856)

Basically good, needs to be applied to vp9dec too which is more or less the
same code.

::: ext/vpx/gstvp8dec.c
@@ +430,2 @@
   g_assert (dec->output_state == NULL);
+  dec->output_state = gst_video_decoder_set_output_state (GST_VIDEO_DECODER
(dec), GST_VIDEO_FORMAT_I420, stream_info.w, stream_info.h, state); /* Use
NULL? Why use input_state? */

Please run all this through gst-indent again after your changes, also you
changed nothing in this line :)

The input state is passed there to copy over things like the pixel-aspect-ratio
and the framerate

@@ +551,3 @@
+        new_output_state =
+            gst_video_decoder_set_output_state (GST_VIDEO_DECODER (dec),
+            GST_VIDEO_FORMAT_I420, img->d_w, img->d_h, dec->output_state);

Must use the input state here

@@ +555,3 @@
+          gst_video_codec_state_unref (dec->output_state);
+        }
+        dec->output_state = new_output_state;

You might want to call gst_video_decoder_negotiate() manually here... not
really required, but you could give a more useful error message if that fails
than when allocate_output_frame() below fails.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.