[Bug 703093] videomeasure: port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703093
  GStreamer | gst-plugins-bad | git

LRN <lrn1986> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lrn1986 at gmail.com

--- Comment #6 from LRN <lrn1986 at gmail.com> 2013-12-06 11:22:53 UTC ---
> @@ +500,3 @@
>        }
> +      sigma_o = sigma_o / elsumm; /*sigma_o = sqrt (sigma_o / elsumm)*/
> +      sigma_m = sigma_m / elsumm; /*sigma_m = sqrt (sigma_m / elsumm)*/
> 
> Why did you remove the sqrt() call here ?
> 
> @@ +504,3 @@
>        tmp1 = (2 * mu_o * mu_m + ssim->const1) * (2 * sigma_om + ssim->const2)
> /
>            ((mu_o * mu_o + mu_m * mu_m + ssim->const1) *
> +          (sigma_o + sigma_m + ssim->const2)); /* (sigma_o^2 + sigma_m^2 +
> ssim->const2) */
> 
> And the squaring here..

Exactly because it's squared later. No sense sqrt'ing it, and then squaring it
back.

As for other comments - ok, i'll try to work myself up to fix these.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.