[Bug 711087] rtpbin: Support Auxiliary streams

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711087
  GStreamer | gst-plugins-good | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #260141|none                        |needs-work
             status|                            |

--- Comment #26 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-12-11 22:20:31 UTC ---
Review of attachment 260141:
 --> (https://bugzilla.gnome.org/review?bug=711087&attachment=260141)

I think the API here is wrong (also the same for the receiver), it needs to be
possible to add more than one aux session per real session (for example to do
both RTX and FEC), in the multicast case, there may be more than one level/type
of FEC (so different aux session with different FEC settings and the receiver
picks the right multicast group based on its needs).

::: gst/rtpmanager/gstrtpbin.c
@@ +3090,3 @@
+    GstPad *srcauxpad = NULL;
+
+    /* if user has set a parent and if it's a bin then remove it */

Why do you do that ?

@@ +3098,3 @@
+
+    /* add auxiliary element to rtpbin */
+    gst_bin_add (GST_BIN_CAST (rtpbin), aux_element);

Need to check the return value

@@ +3111,3 @@
+        "linking auxiliary sender RTP src pad to session");
+    gst_pad_link_full (srcauxpad, session->send_rtp_sink,
+        GST_PAD_LINK_CHECK_NOTHING);

Please check the return value here too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.