[Bug 711084] rtpmanager: add new rtprtxsend and rtprtxreceive elements for retransmission

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711084
  GStreamer | gst-plugins-good | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259245|none                        |needs-work
             status|                            |

--- Comment #56 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-12-12 00:13:01 UTC ---
Review of attachment 259245:
 --> (https://bugzilla.gnome.org/review?bug=711084&attachment=259245)

In the section for "RFC 4585 section 3.5.2 step 4", probably should also allow
early feedback in ptp mode.

::: gst/rtpmanager/rtpsession.c
@@ +1341,3 @@
+  data.new_addr = NULL;
+  g_hash_table_foreach (sess->ssrcs[sess->mask_idx],
+      (GHFunc) compare_rtp_source_addr, (gpointer) & data);

May want to use g_hash_table_find() instead to stop iterating fast if the
answer is FALSE, in that case, the session may be big (very big). Or maybe use
g_hash_table_iter_*().

@@ +1344,3 @@
+  is_doing_rtp_ptp = data.is_doing_ptp;
+
+  /* same but about rtcp */

No need to check rtcp if is_doing_rtp_ptp is FALSE

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.