[Bug 711560] rtpsession: ssrc collision improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711560
  GStreamer | gst-plugins-good | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259641|none                        |needs-work
             status|                            |

--- Comment #22 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-12-12 00:49:01 UTC ---
Review of attachment 259641:
 --> (https://bugzilla.gnome.org/review?bug=711560&attachment=259641)

You must do a downstream caps query first, to try to get the new SSRC from the
rtp session (otherwise the RTP session will have to override it).

::: gst-libs/gst/rtp/gstrtpbasepayload.c
@@ +442,3 @@
+
+        if (!gst_structure_get_uint (s, "ssrc", &ssrc))
+          ssrc = -1;

ssrc is a guint, so you can't make it -1. You need to add another boolean
variable like ssrc_exists

@@ +492,3 @@
+  if (rtpbasepayload_class->src_event)
+    res = rtpbasepayload_class->src_event (rtpbasepayload, event);
+  else

You have a default handler, so this should never be NULL.

@@ +964,3 @@

+  if (g_atomic_int_compare_and_exchange (&payload->
+          priv->notified_first_timestamp, 1, 0)) {

Separate patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.