[Bug 711412] rtpjitterbuffer: Automatically calculate RTX properties based on RTT

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711412
  GStreamer | gst-plugins-good | unspecified

--- Comment #11 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-12-13 05:22:30 UTC ---
Review of attachment 263900:
 --> (https://bugzilla.gnome.org/review?bug=711412&attachment=263900)

Just some coding comments, but don't forget Wim's algorithmic issues first..

::: gst/rtpmanager/gstrtpjitterbuffer.c
@@ +292,3 @@
+  guint32 jitter;
+  GstClockTime prev_rtptime;
+  GstClockTime last_rtptime;

prev_rtptime & last_rtptime are never used

@@ +700,3 @@
   priv->rtx_retry_period = DEFAULT_RTX_RETRY_PERIOD;
+  priv->transit = DEFAULT_TRANSIT;
+  priv->jitter = DEFAULT_JITTER;

You also need to reset transit & jitter on gst_rtp_jitter_buffer_flush_stop()

@@ +1961,3 @@
+      diff = transit - priv->transit;
+    else
+      diff = priv->transit - transit;

diff = ABS (priv->transit - transit)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.