[Bug 720435] rtpbasepayload: Prefer downstream SSRC after collision if possible

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720435
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264173|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-14 09:54:49 UTC ---
Review of attachment 264173:
 --> (https://bugzilla.gnome.org/review?bug=720435&attachment=264173)

::: gst-libs/gst/rtp/gstrtpbasepayload.c
@@ +461,3 @@
+          /* Ignore if we're not currently negotiated */
+          if (!caps)
+            break;

... but there was a collision so it would be good to get a new ssrc?

@@ +473,3 @@
+                " ignoring ssrc collision");
+            res = FALSE;
+            break;

And the same here?

@@ +482,3 @@
+            res = FALSE;
+            gst_caps_unref (peercaps);
+            break;

And in this case you should probably additionally do an GST_ELEMENT_ERROR(). As
the caps are empty, dataflow will fail later and posting a more useful error
here than in the source might be a good idea

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.