[Bug 720388] deinterlace: handle unsupported features caps in passthrough mode

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720388
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264140|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-14 17:16:47 UTC ---
Review of attachment 264140:
 --> (https://bugzilla.gnome.org/review?bug=720388&attachment=264140)

Please also provide a unit test for this :)

::: gst/deinterlace/gstdeinterlace.c
@@ +2399,3 @@
+  caps = gst_caps_new_empty_simple ("video/x-raw");
+  features =
+      gst_caps_features_new (GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY, NULL);

The default is sysmem caps features. No need to do this here.

@@ +2440,3 @@
+  if (gst_deinterlace_can_handle_caps (caps)) {
+    GST_INFO_OBJECT (self, "Unsupported caps features, setting disabled
mode");
+    self->mode = GST_DEINTERLACE_MODE_DISABLED;

This should only happen in auto-mode. Also the mode set by the property should
be kept, just for these caps a different mode should internally be used.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.