[Bug 720345] videobalance: handle unsupported caps features in passthrough mode

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720345
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264098|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-14 17:21:55 UTC ---
Review of attachment 264098:
 --> (https://bugzilla.gnome.org/review?bug=720345&attachment=264098)

::: gst/videofilter/gstvideobalance.c
@@ +77,3 @@
+
+#define VIDEOBALANCE_ALL_CAPS VIDEOBALANCE_CAPS ";" \
+    GST_VIDEO_CAPS_MAKE_WITH_FEATURES ("ANY", VIDEOBALANCE_VIDEO_FORMATS)

For this to all make any sense it would be good to implement support for every
video format, with the help of the pack/unpack functions from
GstVideoFormatInfo. Because why allow NV12/VASurface, but disallow
NV16/VASurface?

And just doing passthrough on any unsupported video format will cause
unexpected behaviour. Maybe we also need a property to select this
auto-passthrough-if-unsupported mode?

@@ +427,3 @@

+static gboolean
+gst_video_balance_can_handle_caps (GstCaps * srccaps)

Also should happen on otherwise unsupported caps (video format!)

@@ +435,3 @@
+  caps = gst_caps_new_empty_simple ("video/x-raw");
+  features =
+      gst_caps_features_new (GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY, NULL);

Not needed, sysmem is there by default

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.