[Bug 720597] decodebin: query allocation always sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720597
  GStreamer | gst-plugins-base | 1.2.1

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |UNCONFIRMED

--- Comment #2 from Julien Isorce <julien.isorce at gmail.com> 2013-12-17 13:03:12 UTC ---
actually I think the reconfigure event is not needed in this case. Because it's
sent before to even try the first negotiation. So that even if the first
negotiation succeeds it will always try to reconfigure.

What happens exactly:

- gst_video_decoder_negotiate from avdec_h264
- gst_video_decoder_negotiate_default
- gst_pad_set_caps
- link pads between decodebin and the next downstream element, and this link
function sends a reconfigure event
- first attempt to negotiation (query allocation/propose/decide)
- negotiation succeeds between decoder and next downstream element
- at this stage the src pad is still marked reconfigure.
- so that the next call the decoder_output_frame re-sends the query allocation.

I do not see why it could have a more optimal format or way of allocation in
this case. So that I think it's unnecessary to again the negotiation. Which is
what I'm trying to fix.

I think if the next downstream element to decodebin is not a sink and is linked
later it will implies to send a reconfigure event, so that in this case it
could have a more optimal format or way of allocation.

If I'm wrong, what am I missing :) ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.