[Bug 697723] audioringbuffer: Reset segdone when releasing audioringbuffer

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Dec 18 04:30:41 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=697723
  GStreamer | gst-plugins-base | 1.0.6

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #5 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2013-12-18 12:30:34 UTC ---
This patch causes playbin gapless playback to become gapful with alsasink.

tools/gst-play-1.0 --gapless a.wav b.wav

This will wait an amount equal to the length of a.wav after playing a.wav, when
using alsasink. When using pulsesink, this does not happens as pulsesink uses
its own commit function.

It seems with this patch, alsasink will loop in commit as it thinks it's back
at playback start. Commenting out "g_atomic_int_set (&buf->segdone, 0);" in
_release fixes the pause, but presumably introduces again the issue fixed here.

So it seems that introduces a bug in the ring buffer (or exposes an existing
one) when a ring buffer is "reused", and I can't tell which atm.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list