[Bug 720692] New: [PATCH] audioringbuffer: track last position across release/acquire

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720692
  GStreamer | gst-plugins-base | unspecified

           Summary: [PATCH] audioringbuffer: track last position across
                    release/acquire
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: vincent.penquerch at collabora.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=264494)
 View: https://bugzilla.gnome.org/attachment.cgi?id=264494
 Review: https://bugzilla.gnome.org/review?bug=720692&attachment=264494

audioringbuffer: track last position across release/acquire

If releasing and reacquiring the ring buffer, such as can happen
when doing gapless playback with playbin, the ring buffer would
get its segone reset to 0, causing it to write as much data out
as was written previously to get back to the same point. Keeping
track of the last position fixes this. The position is tracked
in samples, converted to time, and reconverted to samples with
the new sample rate, in case it changes.

This fixes playbin gapless playback with alsasink.

I'm far from certain about this not breaking other stuff. It seems to work
fine here so far.

The breakage was introduced by
https://bugzilla.gnome.org/show_bug.cgi?id=697723. Hopefully it doesn't
reintroduce it...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.