[Bug 720597] decodebin: query allocation always sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720597
  GStreamer | gst-plugins-base | 1.2.1

--- Comment #7 from Julien Isorce <julien.isorce at gmail.com> 2013-12-19 09:21:14 UTC ---
(In reply to comment #6)
> You probably want to do gst_pad_check_reconfigure () before setcaps, not after.

There is already one call to gst_pad_check_reconfigure just before to enter in
->negotiate, see
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst-libs/gst/video/gstvideodecoder.c#n3277

The pb is that calling setcaps (and gst_pad_peer_query) imply that the
reconfigure flag is set again, see #2 and #5

So my solution is in gst_video_decoder_negotiate_pool:

+gst_pad_check_reconfigure (decoder->srcpad);
+
 g_assert (klass->decide_allocation != NULL);
 ret = klass->decide_allocation (decoder, query);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.