[Bug 707361] video: Add support for 64x32 tiled NV12 color format
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Dec 19 06:28:25 PST 2013
https://bugzilla.gnome.org/show_bug.cgi?id=707361
GStreamer | gst-plugins-base | git
--- Comment #26 from Wim Taymans <wim.taymans at gmail.com> 2013-12-19 14:28:18 UTC ---
Some remarks:
- You now moved the unpacking of the tiled formats to a higher layer, the frame
layer. You seem to want to do this so that you can use extra fields (from the
GstVideoInfo, the x/y tiles) to do the unpacking. Why not place those extra
fields in the last free plane and avoid this extra layer of unpacking?
- You have implemented a default function to fill the x/y tiles in the
GstVideoInfo. When you use GstVideoMeta, how is this updated? where does the
x/y tiles come from? are you going to use the width/height of the GstVideoMeta
for this? You could also store this in the 4th plane..
- frame_pack and frame_unpack seem to only be able to unpack one line of a
frame starting from the leftmost pixel. This seems weird as a general unpack
function.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list