[Bug 719357] audiobasesink: does not drop late buffers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719357
  GStreamer | gst-plugins-base | git

--- Comment #12 from Wim Taymans <wim.taymans at gmail.com> 2013-12-19 20:18:43 UTC ---
(In reply to comment #11)
> (In reply to comment #8)
> > [..]
> > align = sink->next_sample - sample_offset; ==0 means perfect, < 0 means the
> > sample is to be played later than expected and thus alignment would play the
> > sample earlier, > 0 the sample is to be played sooner than expected and thus
> > alignment would delay playback.
> > [..]
> 
> Wim: Isn't this just backwards ^ ? Srsly confused now, will take another
> look at the code.

The confusion is from the fact that alignment makes the sample play at the
wrong time, the timestamp converted to sample_offset is ignored and the sample
is played at the expected next position, aligned to the previous sample.

You don't want to align if that next_sample is behind the read pointer, you
prefer to play the sample at its intended timestamp.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.