[Bug 711412] rtpjitterbuffer: Automatically calculate RTX properties based on RTT

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711412
  GStreamer | gst-plugins-good | unspecified

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264605|none                        |needs-work
             status|                            |

--- Comment #13 from Wim Taymans <wim.taymans at gmail.com> 2013-12-20 19:43:11 UTC ---
(From update of attachment 264605)
>+
>+    if (priv->rtx_delay == DEFAULT_RTX_DELAY) {
>+      if (priv->jitter == DEFAULT_JITTER)
>+        delay = DEFAULT_AUTO_RTX_DELAY;
>+      else
>+        delay = priv->jitter * 2;
>+    } else {
>+      delay = priv->rtx_delay;
>+    }

Same problem as previous patch, jitter is expected to be in milliseconds here.

>+
>+  rtparrival = gst_util_uint64_scale_int (dts, priv->clock_rate, GST_SECOND);
>+
>+  transit = rtparrival - rtptime;
>+
>+  if (G_UNLIKELY (priv->transit != -1)) {
>+    diff = ABS (transit - priv->transit);
>+  } else
>+    diff = 0;
>+
>+  priv->transit = transit;
>+
>+  priv->jitter += diff - ((priv->jitter + 8) >> 4);

.. but here you calculate the jitter in clock-rate.

>+  if (priv->rtx_retry_period == DEFAULT_RTX_RETRY_PERIOD) {
>+    if (priv->avg_rtx_rtt == 0)
>+      calculated_period = DEFAULT_AUTO_RTX_PERIOD;
>+    else
>+      calculated_period =
>+          priv->avg_rtx_rtt * g_queue_get_length (priv->jbuf->packets);
>+  } else {
>+    calculated_period = priv->rtx_retry_period;
>+  }

retry period is unrelated to the amount of packets currently in the
buffer, it should be something based on max-latency of buffer - round-trip

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.