[Bug 658309] souphttpsrc: Add support for getting content size via content-range header

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=658309
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264842|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-24 14:19:19 UTC ---
Review of attachment 264842:
 --> (https://bugzilla.gnome.org/review?bug=658309&attachment=264842)

Please attach it in "git format-patch" format :)

::: ext/soup/gstsouphttpsrc.c
@@ +795,3 @@
+    /* Use HEAD response headers to determine content size if content-length
not included */
+    GST_INFO_OBJECT (src, "Determine size based on HTTP HEAD response
headers");
+    gst_soup_http_src_determine_size (src);

Can't we do the if-branch above in here too?

@@ +1427,3 @@
+  const gchar *header_name, *header_value;
+  SoupMessageHeadersIter iter;
+  GString *log_str = g_string_sized_new (256);

This GString is leaked

@@ +1476,3 @@
+              "content-range")) != NULL) {
+    /* Parse out size from string in format: bytes 0-168042671/168042672 */
+    format = "BYTES%*[^/]/%" G_GUINT64_FORMAT;

Put format directly into the sscanf() call, it makes gcc and clang unhappy
otherwise with -Wformat=2 :) Also you only use this single format here, nothing
else

And sscanf() does not generally support regular expressions AFAIK

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.