[Bug 720805] pad: stop running tasks before deactivation requests?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720805
  GStreamer | gstreamer (core) | 1.2.1

--- Comment #3 from Wind Yuan <feng.yuan at intel.com> 2013-12-25 07:01:10 UTC ---
(In reply to comment #2)
> 1) is what you're supposed to do and what e.g. gst-omx and the androidmedia
> plugin are doing. Before chaining up to the parent class' state change function
> you must make sure that all pads are unlocked.
Agree, actually this was my first patch going to fix this issue.

> 3) can't be implemented because pads can't stop their tasks themselves, the
> code running inside the tasks is the only one who can unlock and stop
> 
> 2) is not a solution because it would break ABI. Current subclasses of
> GstVideoDecoder assume that all data flow has stopped already when stop() is
> called.
If any hook can be added in GstVideoDecoder before change_state should be
better. else subclass has to hook change_state()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.