[Bug 721078] videodecoder: cannot call gst_video_decoder_negotiate without output_state

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721078
  GStreamer | gst-plugins-base | 1.2.1

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |UNCONFIRMED

--- Comment #2 from Julien Isorce <julien.isorce at gmail.com> 2013-12-26 10:49:08 UTC ---
(In reply to comment #1)
> http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=cd52ff313e2c9eca0d20787f598b1d752da4c5f7

I know and this is why mfcdec (by chance ? :) ) does not trigger this
g_return_val_if_fail in master.

> 
> This was not backported to 1.2 at all, so that should happen first before your
> patch makes any sense :) But I think this change is too intrusive for 1.2

You mean the commit
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=cd52ff313e2c9eca0d20787f598b1d752da4c5f7
? if yes then, yup I agree.
Or is my patch too intrusive ?

> 
> Or did I misunderstand anything here?

Well maybe
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=0c2c909497f5f97074cf1b0d26bd14939f892b6f
should not have introduced "g_return_val_if_fail (decoder->priv->output_state,
FALSE);" ?

In other word, in 1.2 branch do we really want to prevent calling
"gst_video_decoder_negotiate" with null output_state ?
Because in master we allow it. (but indeed there is the commit that is too
intrusive to be merged)

Well in the current state, mfcdec triggers the check in 1.2, and not in master.
I'm worry if there are other decoders that do that (set output state in
negotiate), or mfcdec this is just an exception.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.