[Bug 707605] Need "reverse-funnel" element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707605
  GStreamer | gstreamer (core) | git

Reynaldo H. Verdejo Pinochet <reynaldo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262802|none                        |needs-work
             status|                            |

--- Comment #64 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2013-12-26 17:45:03 UTC ---
Review of attachment 262802:
 --> (https://bugzilla.gnome.org/review?bug=707605&attachment=262802)

Just quickly skimming through it

::: plugins/elements/gststreamiddemux.c
@@ +189,3 @@
+  if (demux->active_srcpad != NULL)
+    demux->active_srcpad = NULL;
+

Either there's something missing on that if
block above or the next line makes it unneeded

@@ +224,3 @@
+    GST_OBJECT_UNLOCK (demux);
+  }
+

Drop the else clause and move the
GST_OBJECT_UNLOCK outside the if
block

@@ +278,3 @@
+      GST_OBJECT_LOCK (demux);
+      if (demux->active_srcpad != NULL)
+        demux->active_srcpad = NULL;

See comment #1

::: tests/check/elements/streamiddemux.c
@@ +1,3 @@
+/* GStreamer unit tests for the streamiddemux
+ *
+ * Copyright (C) 2013 LGE

You sure it's not LGE Corporation like on the rest of the files?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.