[Bug 703345] Add support for GstVideoGLTextureUploadMeta

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703345
  GStreamer | gst-plugins-gl | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259798|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-27 10:22:40 UTC ---
Review of attachment 259798:
 --> (https://bugzilla.gnome.org/review?bug=703345&attachment=259798)

::: gst-libs/gst/gl/gstglfilter.c
@@ +38,3 @@
+        GST_VIDEO_CAPS_MAKE_WITH_FEATURES
+        (GST_CAPS_FEATURE_META_GST_VIDEO_GL_TEXTURE_UPLOAD_META,
+            GST_GL_UPLOAD_FORMATS))

This is not correct as you only handle RGBA currently for the texture upload
meta

::: gst-libs/gst/gl/gstglupload.c
@@ +579,3 @@
+  /* GstVideoGLTextureUploadMeta */
+  gl_tex_upload_meta = gst_buffer_get_video_gl_texture_upload_meta (buffer);
+  if (gl_tex_upload_meta) {

here you should also check the limitations of the meta support, i.e. one RGBA
texture. And otherwise fall back to the normal code path

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.