[Bug 704321] Add complete support for GstContext

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704321
  GStreamer | gst-plugins-gl | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259713|none                        |needs-work
             status|                            |

--- Comment #30 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-27 10:34:04 UTC ---
Review of attachment 259713:
 --> (https://bugzilla.gnome.org/review?bug=704321&attachment=259713)

Generally looks good :)

::: gst-libs/gst/gl/gstgldisplay.c
@@ +128,3 @@
+  g_return_val_if_fail (context != NULL, FALSE);
+
+  GST_DEBUG_CATEGORY_GET (gst_context, "GST_CONTEXT");

Do this only once in a central place

::: gst-libs/gst/gl/gstglutils.c
@@ +435,3 @@
+
+  if (!GST_CAT_CONTEXT)
+    GST_DEBUG_CATEGORY_GET (GST_CAT_CONTEXT, "GST_CONTEXT");

Not necessarily threadsafe, do it once in a central place

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.