[Bug 721078] videodecoder: cannot call gst_video_decoder_negotiate without output_state

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Dec 27 06:08:08 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=721078
  GStreamer | gst-plugins-base | 1.2.1

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264898|0                           |1
        is obsolete|                            |

--- Comment #4 from Julien Isorce <julien.isorce at gmail.com> 2013-12-27 14:08:02 UTC ---
Created an attachment (id=264930)
 View: https://bugzilla.gnome.org/attachment.cgi?id=264930
 Review: https://bugzilla.gnome.org/review?bug=721078&attachment=264930

mfcdec: configure output_state before to call gst_video_decoder_negotiate

Ok so I fixed mfcdec instead. Actually it's the only video decoder that defines
GstVideoDecoderClass::negotiate. (I did a quick check in -base, -good, -ugly,
-bad, gst-vaapi, gst-omx)

In almost all video decoders it's done like this:
- do not define GstVideoDecoderClass::negotiate
- define a function named "myvideodec_negotiate" that successively calls
"gst_video_decoder_set_output_state" then "gst_video_decoder_negotiate"
- call "myvideodec_negotiate" manually

So I did it for mfcdec so that it's now useable in 1.2 branch. I tested it with
playbin and seeking works too

(Note that the bug title should be changed but it seems I have not the rights
to do it)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list