[Bug 721078] mfcdec: fails to negotiate

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721078
  GStreamer | gst-plugins-bad | 1.2.1

--- Comment #6 from Julien Isorce <julien.isorce at gmail.com> 2013-12-27 15:18:23 UTC ---
(In reply to comment #5)
> Review of attachment 264930 [details]:
> 
> This is only needed for 1.2?
> 
Yes because there is not "g_return_val_if_fail (decoder->priv->output_state,
FALSE);" in "gst_video_decoder_negotiate" of master branch due to the commit
that has not been merged because to intrusive.

> I don't think this is correct, what negotiate() was doing should still be done
> whenever GstVideoDecoder::negotiate() is called

but what is done in negotiate() (.i.e. "gst_mfc_dec_negotiate") is mainly to
call "gst_video_decoder_set_output_state". Whereas there is a
"g_return_val_if_fail (decoder->priv->output_state, FALSE);" in
"gst_video_decoder_negotiate". So that's a bit contradictious :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.