[Bug 721245] New: gstreamer1-gst-plugins-good 1.2.1 fail to build on Leopard (!RUN_NS_APP_THREAD case)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721245
  GStreamer | gst-plugins-good | unspecified

           Summary: gstreamer1-gst-plugins-good 1.2.1 fail to build on
                    Leopard (!RUN_NS_APP_THREAD case)
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Mac OS
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: jeremyhu at freedesktop.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Firstly, the check for deployment target is incorrect.  Please apply:

--- sys/osxvideo/osxvideosink.h.orig    2013-12-30 12:02:55.000000000 -0800
+++ sys/osxvideo/osxvideosink.h    2013-12-30 12:03:16.000000000 -0800
@@ -42,7 +42,7 @@ GST_DEBUG_CATEGORY_EXTERN (gst_debug_osx

 /* The hack doesn't work on leopard, the _CFMainPThread symbol
  * is doesn't exist in the CoreFoundation library */
-#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_5
+#if MAC_OS_X_VERSION_MIN_REQUIRED < 1060
 #ifdef RUN_NS_APP_THREAD
 #undef RUN_NS_APP_THREAD
 #endif
@@ -122,7 +122,7 @@ GType gst_osx_video_sink_get_type(void);
 @end


-#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_5
+#if MAC_OS_X_VERSION_MIN_REQUIRED < 1060
 @interface GstWindowDelegate : NSObject
 #else
 @interface GstWindowDelegate : NSObject <NSWindowDelegate>

---

gcc-4.2 will set MAC_OS_X_VERSION_MIN_REQUIRED to the current system version by
default (eg 1058 when running on 10.5.8), so the check for <= 1050 will fail on
Leopard systems with updates applied.

After that, the build still fails:

osxvideosink.m: In function 'gst_osx_video_sink_call_from_main_thread':
osxvideosink.m:96: error: 'GstOSXVideoSinkClass' has no member named
'ns_app_thread'
osxvideosink.m:99: error: 'GstOSXVideoSinkClass' has no member named
'ns_app_thread'
osxvideosink.m: In function 'gst_osx_videosink_check_main_run_loop':
osxvideosink.m:168: error: 'GstOSXVideoSinkClass' has no member named
'ns_app_thread'
osxvideosink.m: In function 'gst_osx_video_sink_run_cocoa_loop':
osxvideosink.m:198: error: 'GstOSXVideoSinkClass' has no member named
'ns_app_thread'
osxvideosink.m: In function 'gst_osx_video_sink_stop_cocoa_loop':
osxvideosink.m:236: error: 'sink_klass' undeclared (first use in this function)
osxvideosink.m:236: error: (Each undeclared identifier is reported only once
osxvideosink.m:236: error: for each function it appears in.)
osxvideosink.m: In function 'gst_osx_video_sink_osxwindow_create':
osxvideosink.m:281: error: 'GstOSXVideoSinkClass' has no member named
'ns_app_thread'
osxvideosink.m: In function 'gst_osx_video_sink_class_init':
osxvideosink.m:582: error: 'GstOSXVideoSinkClass' has no member named
'ns_app_thread'
osxvideosink.m: In function '-[GstOSXVideoSinkObject createInternalWindow]':
osxvideosink.m:814: error: 'GstOSXVideoSink' has no member named 'app_started'
osxvideosink.m:817: error: 'GstOSXVideoSink' has no member named 'app_started'

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.