[Bug 658309] souphttpsrc: Add support for getting content size via content-range header

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Dec 31 02:02:34 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=658309
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265037|none                        |needs-work
             status|                            |

--- Comment #24 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-31 10:02:26 UTC ---
Review of attachment 265037:
 --> (https://bugzilla.gnome.org/review?bug=658309&attachment=265037)

::: ext/soup/gstsouphttpsrc.c
@@ +1455,3 @@
+      basesrc->segment.duration = src->content_size;
+      gst_element_post_message (GST_ELEMENT (src),
+          gst_message_new_duration_changed (GST_OBJECT (src)));

The reason why I wanted this merged into this function was that there's some
duplicated code here...

@@ +1510,3 @@
+    basesrc->segment.duration = src->content_size;
+    gst_element_post_message (GST_ELEMENT (src),
+        gst_message_new_duration_changed (GST_OBJECT (src)));

... which is duplicated here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list