[Bug 721268] New: v4l2: Fix Coverity complaint...

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Dec 31 04:31:43 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=721268
  GStreamer | gst-plugins-good | git

           Summary: v4l2: Fix Coverity complaint...
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: sebras at hotmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Coverity reported this:

** CID 1146960:  Unchecked return value  (CHECKED_RETURN)
/gst-plugins-good/sys/v4l2/gstv4l2object.c: 2334 in
gst_v4l2_object_get_nearest_size()
/gst-plugins-good/sys/v4l2/gstv4l2object.c: 2339 in
gst_v4l2_object_get_nearest_size()

In gst_v4l2_object_get_nearest_size() there is a workaround to retrieve the
current format and save it, then probe a new format and then restore the saved
format at the end of the function. The calls fail to check the return valueto
v4l2_ioctl() when restoring the saved format. This patch adds the checks and
prints a GST_WARNING when the call fails.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list