[Bug 693481] gst-launch: Use signalfd() to handle keyboard interruption

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Feb 13 01:05:35 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=693481
  GStreamer | gstreamer (core) | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235842|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-13 09:05:28 UTC ---
Review of attachment 235842:
 --> (https://bugzilla.gnome.org/review?bug=693481&attachment=235842)

::: tools/gst-launch.c
@@ +38,3 @@
 #endif
 #ifndef DISABLE_FAULT_HANDLER
+#include <glib-unix.h>

Will this block only be used on Unix-like platforms?

@@ +517,3 @@
+      gst_message_new_application (GST_OBJECT (pipeline),
+          gst_structure_new ("GstLaunchInterrupt",
+              "message", G_TYPE_STRING, "Pipeline interrupted", NULL)));

As the signal handler is now called from the main loop you don't need to use
this message anymore and can do what happens during the handling of the message
here already.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list