[Bug 693826] add dmabuf support in -good
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Feb 14 09:12:39 PST 2013
https://bugzilla.gnome.org/show_bug.cgi?id=693826
GStreamer | gst-plugins-good | 1.0.5
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #236104|none |needs-work
status| |
--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-14 17:12:34 UTC ---
Review of attachment 236104:
--> (https://bugzilla.gnome.org/review?bug=693826&attachment=236104)
Overall, this should be in gstreamer core or gst-plugins-base in one of the
libraries
::: gst/dmabuf/gstdmabuf.c
@@ +39,3 @@
+ gpointer data;
+ gsize size;
+} dmabuf_mem;
Part of this struct should probably be public to allow code to get the fd for
the dmabuf instead of requiring mapping. E.g. could be done with a
GstBufferMeta for dmabuf, or also by having a GstDmaBufMemory public struct
(and internally using one that has more fields, see GstEvent and GstEventImpl
for example)
@@ +70,3 @@
+ /* do not mmap twice the buffer */
+ if (res)
+ return res;
Depending on the flags it should do something... e.g. if mapped read-only
before and write is requested it should fail
@@ +166,3 @@
+
+GstMemory *
+dmabuf_mem_alloc (gint fd, gsize size)
Maybe the allocator should be per fd: gst_dmabuf_allocator_new(int fd);
@@ +192,3 @@
+{
+ return mem->allocator == _dmabuf_allocator;
+}
You can just check the mem_type of the allocator, no need for a new function
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list