[Bug 693826] dmabuf-based GstMemory and GstAllocator incl. v4l2src support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693826
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236588|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-18 14:04:58 UTC ---
Review of attachment 236588:
 --> (https://bugzilla.gnome.org/review?bug=693826&attachment=236588)

::: gst-libs/gst/allocators/gstdmabuf.c
@@ +23,3 @@
+#include "gstdmabuf.h"
+#include <sys/mman.h>
+#include <unistd.h>

These two includes should be in the #ifdef HAVE_MMAP block too

@@ +42,3 @@
+  gint mmap_count;
+  GMutex lock;
+} GstDmaBufMemory;

same for this

@@ +220,3 @@
+ * gst_dmabuf_allocator_obtain
+ * return a dmabuf allocator
+ * Use gst_object_unref() to release the allocator after usage.

Document that this can return NULL and when

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.