[Bug 693996] basetransform: audioresample shutdown unit test fails with 'gst_audio_info_from_caps: caps != NULL' in transform_size

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693996
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.0.6

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-02-21 12:01:56 UTC ---
Committed, but without the && !gst_pad_is_active(pad) which is not needed (if
caps are actually supposed to be NULL this code path should not be called, so
if they are NULL we can be sure that's not right).

commit 5a73d15c80d7fbfb4c45e5405c7cfa34571e70a2
Author: Tim-Philipp Müller <tim at centricular.net>
Date:   Sat Feb 16 23:02:21 2013 +0000

    basetransform: don't pass NULL outcaps to transform_size on shutdown

    gst_pad_get_current_caps() on the source pad might yield NULL caps
    if we're being shut down and the source pad has already been
    deactivated by the other thread that's changing state. Just bail
    out in that case, instead of passing NULL caps to the transform_size
    function, which it might not expect.

    Fixes spurious warnings in audioresample shutdown unit test.

    https://bugzilla.gnome.org/show_bug.cgi?id=693996

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.