[Bug 694374] [patch] Improve the clarity of the Alpha filter's properties

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=694374
  GStreamer | gst-plugins-good | git

--- Comment #5 from Youness Alaoui <youness.alaoui at collabora.co.uk> 2013-02-21 20:06:24 UTC ---
Created an attachment (id=237104)
 View: https://bugzilla.gnome.org/attachment.cgi?id=237104
 Review: https://bugzilla.gnome.org/review?bug=694374&attachment=237104

alpha: Do not override the method with custom r/g/b values

Cool! I'd suggest in the last commit to replace "The target red color value" by
"The target red color value for custom RGB chroma" (same for green and blue) to
make it clear that they are unused/irrelevant if the method is not set
correctly.
Note though that the custom r/g/b settings will override the method if set to
green/blue (depending on the order they appear in in the g_object_set), so I'm
attaching a patch (against master) that will not use the target-r/g/b values
unless the method is set to custom.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.