[Bug 657343] [patch] add PES support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=657343
  GStreamer | gst-plugins-bad | git

--- Comment #22 from Stas Sergeev <stsp at list.ru> 2013-01-03 17:41:10 UTC ---
(In reply to comment #17)
> Review of attachment 196643 [details]:
Sorry, I haven't answered this one because of some
confusion with another comment...

> ::: gst/mpegtsdemux/pesparse.c
> @@ +337,2 @@
>      if (res->extension_field_length) {
> +      res->stream_id_extension_data = data;
> 
> There seems to be something missing here.
> 
> The original code does:
> * read and advance data by 1 byte
> * advance data by res->extension_field_length
Yes.

> Your code does:
> * read data byte
The extension_data[0] byte.

> * advance data by res->extension_field_length
Yes, because the res->extension_field_length==1 usually.
And if it is >1, then this code is still correct: all it
does is to bypass the extension_data bytes. The byte we
read above, is just the extension_data[0] byte, so it doesn't
require an extra increment. We read first byte of an array
and then skip the entire array, so that is fine.

But I can see the line:
---
     length -= res->extension_field_length + 1;
---
which would need to remove +1 then...
I'll upload the patch with this fixed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.