[Bug 681818] h264parse: evaluate vui parameters only when they where parsed and set

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=681818
  GStreamer | gst-plugins-bad | 0.10.23

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |mnauw at users.sourceforge.net
         Resolution|                            |FIXED

--- Comment #1 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2013-01-15 19:14:53 UTC ---
Thanks for noting this, but if I read things right, it should suffice to
0-initialize the SPS VUI parameters (so all the _present flags end up 0), which
is done in the following commit:

[on master]
commit c20d13d8f8e54e3ee01f85d41a9f17ff359b5215
Author: Mark Nauwelaerts <mnauw at users.sourceforge.net>
Date:   Sat Jan 12 13:15:02 2013 +0100

    codecparsers: h264: zero-initialize SPS VUI parameters

    ... so all 'present' flags indicate no presence of optional parts
    in case VUI parameters end up not being parsed.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=681818

[on 0.10]
commit c20d13d8f8e54e3ee01f85d41a9f17ff359b5215
Author: Mark Nauwelaerts <mnauw at users.sourceforge.net>
Date:   Sat Jan 12 13:15:02 2013 +0100

    codecparsers: h264: zero-initialize SPS VUI parameters

    ... so all 'present' flags indicate no presence of optional parts
    in case VUI parameters end up not being parsed.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=681818

[Not sure/clear about 1.0 branch these days ...]

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.