[Bug 692272] codecparsers: vc1: drop superfluous DQBEDGE

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jan 22 02:34:42 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=692272
  GStreamer | gst-plugins-bad | git

--- Comment #2 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-01-22 10:34:36 UTC ---
(In reply to comment #1)
> I'm actually a bit confused by the comments in the header file, do they make
> sense at all?

I think this is what Thibault meant: let dqbedge represent DQSBEDGE if
dqprofile == GST_VC1_DQPROFILE_SINGLE_EDGE or DQDBEDGE if dqprofile ==
GST_VC1_DQPROFILE_DOUBLE_EDGE instead.

> What you suggest makes sense as far as I can tell: rename dqsbedge to dqbedge,
> and remove dqbedge, right?

Yes, this is exactly what I had in mind.

> We could just rename dqbedge to 'unused' or so with a 'FIXME: remove' comment,
> then we break API but maintain ABI compatibility.

Sure. I will cook a patch with this idea.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list