[Bug 692388] [API] codecparsers: vc1: parse slice headers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=692388
  GStreamer | gst-plugins-bad | git

--- Comment #4 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-01-23 15:31:11 UTC ---
(In reply to comment #2)
> (From update of attachment 234201 [details])
> Looks fine. Perhaps mark the sequence header structure argumen as const  * if
> it's not going to be touched/changed. And please add a 'Since: 1.2' or 'Since:
> 1.0.6' at the end of the gtk-doc blob.

Unfortunately, I can't make seqhdr const * because
parse_frame_header_advanced() may alter it through calculate_mb_size().

If we want seqhdr to be const * for all VC-1 API, then I think we probably
should write some gst_vc1_finalise_sequence_header() similar in sense to
gst_mpeg_video_finalise_sequence_header() where we compute the required fields
that may be changed subsequently after a sequence header, e.g. frame header.
WDYT?

Meanwhile, could I simply push that patch with the "Since:" addition?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.